06-01-2015, 11:44 PM
(06-01-2015, 11:33 PM)Malong link Wrote:Nice project. Looking at the commits there is hard coding or spaghetti code can be cleaned up. The fromArray method can just parse XML and put the values into variables (named by the tag names) rather than parsing the textual XML tags. If the servers should change, editing only a text file that contains the list of servers would allow for modular changes instead of editing hard coded servers inside this method. The load method could read from a text file rather than hard code the urls inside the code. You can edit the block inside updateServerData which checks the selected frame against the name of the selection by matching the selection against the value of the name.
Thanks. So you want me to use methods to parse XML instead of just splitting the text? For the text file, I also considered that but I first started coding this just for me so I did not add something like this, but I can later on. For the updateServerData part, I don't know exactly what you mean. Could you maybe explain that part again? If you want to you can add a push request to the github repository.
Loots:
?.?.12 - Wormbane
4.6.18 - Penetrator
?.?.12 - Wormbane
4.6.18 - Penetrator