19-05-2012, 04:04 AM
Thanks for the great script. I find it very convenient to be able to store links to various often-used pages in the side bar.
---
I have a small suggestion regarding the way the links are stored. This change would allow links which contain commas (such as forum threads) to be specified.
Instead of using [tt]join()[/tt] and [tt]split(",")[/tt] to create and display the list of links, use [tt]join("|")[/tt] and [tt]split("|")[/tt]. As it is now, if there is a comma in a link, the script splits the link at the comma causing the list to display incorrectly. By using the [tt]|[/tt] symbol to separate the links, this can be avoided.
To implement this change, edit the [tt]join[/tt] and [tt]split[/tt] methods on lines 96, 114, 132, 169, 186, 198, 222, 232, and 242.
---
Also, I noticed something about the way the website handles the crafting pages. It seems that the website uses a "p=" parameter to determine which character receives the crafting experience points. All the crafting pages for my first character end in [tt]p=1[/tt]. All the crafting pages for my second character end in [tt]p=2[/tt]. If the wrong number is used, the item is crafted but the experience points are not gained. This means, for example, that if I wanted to store a link for salvaging metal in the side bar, it would only work for one of the characters.
So far, I have not come up with any possible solutions besides saving a separate link for each character. I don't really consider this a problem with the script - it is just unfortunate that the website requires this parameter. Just wanted to mention this for those who have multiple characters.
---
Thanks again for the script.
---
I have a small suggestion regarding the way the links are stored. This change would allow links which contain commas (such as forum threads) to be specified.
Instead of using [tt]join()[/tt] and [tt]split(",")[/tt] to create and display the list of links, use [tt]join("|")[/tt] and [tt]split("|")[/tt]. As it is now, if there is a comma in a link, the script splits the link at the comma causing the list to display incorrectly. By using the [tt]|[/tt] symbol to separate the links, this can be avoided.
To implement this change, edit the [tt]join[/tt] and [tt]split[/tt] methods on lines 96, 114, 132, 169, 186, 198, 222, 232, and 242.
---
Also, I noticed something about the way the website handles the crafting pages. It seems that the website uses a "p=" parameter to determine which character receives the crafting experience points. All the crafting pages for my first character end in [tt]p=1[/tt]. All the crafting pages for my second character end in [tt]p=2[/tt]. If the wrong number is used, the item is crafted but the experience points are not gained. This means, for example, that if I wanted to store a link for salvaging metal in the side bar, it would only work for one of the characters.
So far, I have not come up with any possible solutions besides saving a separate link for each character. I don't really consider this a problem with the script - it is just unfortunate that the website requires this parameter. Just wanted to mention this for those who have multiple characters.
---
Thanks again for the script.
CC_Warden_Kip | CC_Sentinel_Kip | CC_Guard_Kip | CC_Zweihander_Kip | CC_Marksman_Kip | CC_Pavise_Kip | CC_Peltast_Kip | CC_Marauder_Kip | others...