NI Server Browser

[Jalau]

Interesting.  Thanks.

No problem.

[human_being]

Awesome!

[Jalau]

Awesome!

Thanks mate!

[Deerpig]

Awesome stuff, will definitely use! Thanks for all the hard work.

[Jalau]

Awesome stuff, will definitely use! Thanks for all the hard work.

No problem man

[Priest]

Good work . Thank you

[Malong]

So you want me to use methods to parse XML instead of just splitting the text?

You don't have to, but you treat the xml as text instead of xml, which Java has a built in API to handle. You can translate it to an object model and read the elements. If you ever need more elements from the future out of the xml, this makes it more extensible too. JAXP gives some interfaces for this.

For the updateServerData part, I don't know exactly what you mean. Could you maybe explain that part again?

Yeah that was unclear, sorry. I meant this block below. I think you can return the name of the selected frame and perform a string compare to the data.getName, rather than check every single combination for a mismatch.

Code:

+            if (data.getName().contains("EU") && !SettingsFrame.eu.isSelected())
+                return;
+
+            if (data.getName().contains("NA") && !SettingsFrame.na.isSelected())
+                return;
+
+            if (data.getName().contains("AU") && !SettingsFrame.au.isSelected())
+                return;
+
+            if (data.getName().contains("Normal") && !SettingsFrame.normal.isSelected())
+                return;
+
+            if (data.getName().contains("Hard") && !SettingsFrame.hard.isSelected())
+                return;
+
+            if (data.getName().contains("Ragnarok") && !SettingsFrame.ragnarok.isSelected())
+                return;
+
+            if (data.getName().contains("Event") && !SettingsFrame.other.isSelected())
+                return;
+
+            if (data.getName().contains("Cavalry") && !SettingsFrame.cavalry.isSelected())
+                return;

[Jalau]

Good work . Thank you

No problem.

Spoiler

[quote author=Jalau link=topic=37875.msg214646#msg214646 date=1420587858]So you want me to use methods to parse XML instead of just splitting the text?

You don't have to, but you treat the xml as text instead of xml, which Java has a built in API to handle. You can translate it to an object model and read the elements. If you ever need more elements from the future out of the xml, this makes it more extensible too. JAXP gives some interfaces for this.

For the updateServerData part, I don't know exactly what you mean. Could you maybe explain that part again?

Yeah that was unclear, sorry. I meant this block below. I think you can return the name of the selected frame and perform a string compare to the data.getName, rather than check every single combination for a mismatch.

Code:

+            if (data.getName().contains("EU") && !SettingsFrame.eu.isSelected())
+                return;
+
+            if (data.getName().contains("NA") && !SettingsFrame.na.isSelected())
+                return;
+
+            if (data.getName().contains("AU") && !SettingsFrame.au.isSelected())
+                return;
+
+            if (data.getName().contains("Normal") && !SettingsFrame.normal.isSelected())
+                return;
+
+            if (data.getName().contains("Hard") && !SettingsFrame.hard.isSelected())
+                return;
+
+            if (data.getName().contains("Ragnarok") && !SettingsFrame.ragnarok.isSelected())
+                return;
+
+            if (data.getName().contains("Event") && !SettingsFrame.other.isSelected())
+                return;
+
+            if (data.getName().contains("Cavalry") && !SettingsFrame.cavalry.isSelected())
+                return;

[Malong]

Never knew about the xml api. I will look into it. Can you provide any link?

Here you go

For the part with the frame. You want me to compare the name of the data with the name of what? Because the Settings Frames name is always Setting frame and if I print out the name of the checkbox it will probably result in eu/na/au etc. That doesn't changes anything, does it?

Maybe, if possible, compare the name of the data with the text of the checkbox (given by your instantiation). It just makes the code cleaner.

[Lothar]

Very well ,thank you for your work